Backport use of thread delay over sleep and handle dispose in FileSystemMainDomLock#18151
Merged
AndyButland merged 3 commits intov13/devfrom Feb 12, 2025
Conversation
Member
|
@AndyButland I've marked the related PRs for release 13.7.0, which is where I think it will go? |
Contributor
Author
|
@JasonElkin - do you think you'd have time to look over this one please, just as a second pair of eyes that I've backported your amend to 13 correctly? Thanks if so. |
JasonElkin
previously requested changes
Feb 11, 2025
Contributor
JasonElkin
left a comment
JasonElkin
left a comment
There was a problem hiding this comment.
Umbraco-CMS/src/Umbraco.Infrastructure/Runtime/FileSystemMainDomLock.cs
Lines 148 to 149 in e5a1398
Should be replaced by a call to ReleaseLock()
Contributor
Author
|
Thanks @JasonElkin, have updated. I'll include this in the 13.7 release candidate due out today. |
AndyButland
deleted the
v13/task/handle-dispose-and-thread-delay-in-file-system-lock
branch
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This backports the changes applied in PRs #18119 and #18147.
Test steps are described in the second linked PR. I've verified these on this PR for Umbraco 13.